Skip to content

Commit

Permalink
Fix updates (#6141)
Browse files Browse the repository at this point in the history
  • Loading branch information
xinbenlv committed Dec 15, 2022
1 parent 0c93c12 commit bd12378
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions EIPS/eip-5453.md
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,8 @@ interface IERC5453EndorsementDataTypeB {
}
```

See [`IERC5453.sol`](../assets/eip-5453/IERC5453.sol).

### Behavior specification

As specified in [EIP-5750 General Extensibility for Method Behaviors](./eip-5750.md), any compliant method that has an `bytes extraData` as its
Expand Down Expand Up @@ -175,8 +177,6 @@ could balance a wider range of use cases. E.g. the same use cases of EIP-2612 an
2. We chose to include both `validSince` and `validBy` to allow maximum flexibility in expiration. This can be also be supported by EVM natively at if adopted [EIP-5081](./eip-5081.md) but EIP-5081 will not be adopted anytime soon, we choose to add these two numbers in our protocol to allow
smart contract level support.



## Backwards Compatibility

The design assumes a `bytes calldata extraData` to maximize the flexibility of future extensions. This assumption is compatible with [EIP-721](eip-721.md), [EIP-1155](eip-1155.md) and many other ERC-track EIPs. Those that aren't, such as [EIP-20](./eip-20.md), can also be updated to support it, such as using a wrapper contract or proxy upgrade.
Expand Down Expand Up @@ -258,6 +258,8 @@ abstract contract AERC5453Endorsible is EIP712,
```

See [`AERC5453.sol`](../assets/eip-5453/AERC5453.sol)

### Reference Implementation of `EndorsableERC721`

Here is a reference implementation of `EndorsableERC721` that achieves similar behavior of [EIP-4494](./eip-4494.md).
Expand Down Expand Up @@ -287,6 +289,8 @@ contract EndorsableERC721 is ERC721, AERC5453Endorsible {
}
```

See [`EndorsableERC721.sol`](../assets/eip-5453/EndorsableERC721.sol)

### Reference Implementation of `ThresholdMultiSigForwarder`

Here is a reference implementation of ThresholdMultiSigForwarder that achieves similar behavior of multi-sig threshold approval
Expand Down Expand Up @@ -324,6 +328,8 @@ contract ThresholdMultiSigForwarder is AERC5453Endorsible {
```

See [`ThresholdMultiSigForwarder.sol`](../assets/eip-5453/ThresholdMultiSigForwarder.sol)

## Security Considerations

### Replay Attacks
Expand Down

0 comments on commit bd12378

Please sign in to comment.