Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-150: Add information about previous gas costs #1140

Merged
merged 4 commits into from
Sep 27, 2018

Conversation

chfast
Copy link
Member

@chfast chfast commented Jun 7, 2018

Because Yellow Paper only describes the latest mainnet hard fork, there is not official source of information were the gas costs before the changes of EIP-150 are provided.

Because Yellow Paper only describes the latest mainnet hard fork, there is not official source of information were the gas costs before the changes of EIP-150 are provided.
@chfast
Copy link
Member Author

chfast commented Jun 7, 2018

CC @pirapira

@chfast
Copy link
Member Author

chfast commented Jun 11, 2018

CC @vbuterin

@fulldecent
Copy link
Contributor

@chfast Please see https://github.com/ethereum/yellowpaper#versions this includes prior versions of the Yellow Paper as affected by each hard fork.

Please less mentions here and more asking questions like this on Stack Overflow.

@MicahZoltu
Copy link
Contributor

I think having the previous values in the EIP is useful. The yellowpaper is generally known to be incredibly hard to read, and often times internet searches turn up EIPs rather than SO or yellowpaper. I personally don't see a problem with including this, especially since someone else did all of the work to research it and submit the PR.

@fulldecent
Copy link
Contributor

Aah. I see see we are updating the EIP here, not the yellow paper. Yes, I totally agree, this is helpful.

@ali8889
Copy link

ali8889 commented Aug 19, 2018

???

@Arachnid Arachnid requested a review from vbuterin August 28, 2018 11:53
@axic
Copy link
Member

axic commented Aug 31, 2018

I vote for merging this.

@Arachnid what is process of merging such a change?

@axic
Copy link
Member

axic commented Sep 20, 2018

@vbuterin can you approve this?

@nicksavers
Copy link
Contributor

Why is it necessary to know what they were previously?
Leaving them out would make the EIP more general and could be applied whatever they were.

@fulldecent
Copy link
Contributor

If previous gas costs are not relevant, then the words "increase gas cost to" can be changed to "set gas cost to".

@axic
Copy link
Member

axic commented Sep 21, 2018

I think EIP certainly is locked into being applied to a certain state. Look at the other wording, "replace this calculation with X". I think it is relevant to apply the previous cost there.

@gcolvin gcolvin merged commit e201c50 into ethereum:master Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants