Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-1474: Move status to draft #5986

Closed
wants to merge 6 commits into from

Conversation

macfarla
Copy link
Contributor

Signed-off-by: Sally MacFarlane macfarla.github@gmail.com

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@github-actions github-actions bot added c-status Changes a proposal's status s-draft This EIP is a Draft t-interface labels Nov 16, 2022
@eth-bot
Copy link
Collaborator

eth-bot commented Nov 16, 2022

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):


(fail) eip-1474.md

classification
statusChange
  • eip-1474 state was changed from stagnant to draft
  • eip-1474.md is in state stagnant at the base commit, not draft or last call or review; an EIP editor needs to approve this change
  • This PR requires review from one of [@lightclient, @axic, @SamWilsn, @Pandapip1]
  • eip-1474.md requires approval from one of (@bitpshr, @rekmarks)

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@Pandapip1 Pandapip1 changed the title EIP-1474 - change status to draft Update EIP-1474: Move status to draft Nov 17, 2022
@macfarla
Copy link
Contributor Author

On further reflection - much of the content of this EIP is now duplicated here https://github.com/ethereum/execution-apis/ - maybe it would be better for this EIP to specify the generics - error handling, error codes, and how to propose new methods - and leave the specification of the methods and their parameters to the execution-apis spec repo

@Pandapip1
Copy link
Member

On further reflection - much of the content of this EIP is now duplicated here https://github.com/ethereum/execution-apis/ - maybe it would be better for this EIP to specify the generics - error handling, error codes, and how to propose new methods - and leave the specification of the methods and their parameters to the execution-apis spec repo

That's by design. Until we've completely migrated Core EIPs to the new repos, it's a good idea to have the duplicate content.

@SamWilsn
Copy link
Contributor

On further reflection - much of the content of this EIP is now duplicated here https://github.com/ethereum/execution-apis/ - maybe it would be better for this EIP to specify the generics - error handling, error codes, and how to propose new methods - and leave the specification of the methods and their parameters to the execution-apis spec repo

Yep, I think you have the right idea. The list of RPC methods should be maintained over on execution-apis.

@SamWilsn SamWilsn closed this Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-status Changes a proposal's status s-draft This EIP is a Draft t-interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants