Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EIP-6059: Parent-Governed Nestable Non-Fungible Tokens standard #6059

Merged
merged 6 commits into from
Dec 15, 2022
Merged

Add EIP-6059: Parent-Governed Nestable Non-Fungible Tokens standard #6059

merged 6 commits into from
Dec 15, 2022

Conversation

ThunderDeliverer
Copy link
Contributor

This EIP draft proposal includes RMRK team's work on developing an NFT standard where an NFT can own and manage multiple other NFTs.

@ThunderDeliverer
Propose Parent-Governed Nestable Non-Fungible Tokens standard
0a64e8d 
RMRK team has developed a next step in NFT evolution where one NFT can
own and manage other NFTs.
@github-actions github-actions bot added c-new Creates a brand new proposal e-number Waiting on EIP Number assignment s-draft This EIP is a Draft t-erc labels Nov 28, 2022
@eth-bot
Copy link
Collaborator

eth-bot commented Nov 28, 2022 •
edited
Loading

All tests passed; auto-merging...

(pass) eip-6059.md

classification
updateEIP
  • passed!

(pass) assets/eip-6059/contracts/INestable.sol

classification
ambiguous
  • file assets/eip-6059/contracts/INestable.sol is associated with EIP 6059; because there are also changes being made to EIPS/eip-6059.md all changes to corresponding assets are also allowed

(pass) assets/eip-6059/contracts/NestableToken.sol

classification
ambiguous
  • file assets/eip-6059/contracts/NestableToken.sol is associated with EIP 6059; because there are also changes being made to EIPS/eip-6059.md all changes to corresponding assets are also allowed

(pass) assets/eip-6059/contracts/mocks/ERC721Mock.sol

classification
ambiguous
  • file assets/eip-6059/contracts/mocks/ERC721Mock.sol is associated with EIP 6059; because there are also changes being made to EIPS/eip-6059.md all changes to corresponding assets are also allowed

(pass) assets/eip-6059/contracts/mocks/NestableTokenMock.sol

classification
ambiguous
  • file assets/eip-6059/contracts/mocks/NestableTokenMock.sol is associated with EIP 6059; because there are also changes being made to EIPS/eip-6059.md all changes to corresponding assets are also allowed

(pass) assets/eip-6059/hardhat.config.ts

classification
ambiguous
  • file assets/eip-6059/hardhat.config.ts is associated with EIP 6059; because there are also changes being made to EIPS/eip-6059.md all changes to corresponding assets are also allowed

(pass) assets/eip-6059/package.json

classification
ambiguous
  • file assets/eip-6059/package.json is associated with EIP 6059; because there are also changes being made to EIPS/eip-6059.md all changes to corresponding assets are also allowed

(pass) assets/eip-6059/test/nestable.ts

classification
ambiguous
  • file assets/eip-6059/test/nestable.ts is associated with EIP 6059; because there are also changes being made to EIPS/eip-6059.md all changes to corresponding assets are also allowed

@ThunderDeliverer
Assign EIP number
c661e4d 
EIP number 6059 was assigned as this is the number of the PR to add this
proposal.

This was doen before being assigned the EIP number by one of the editors
based on the common practice of assigning EIP numbers based on the PR
number at which the proposal was added. In case the number of the
proposal should be different, the number can easiliy be changed.
@ThunderDeliverer
Add discussion URI and minor text-fixes
4b6fa50 
The discussion URI was added and some minor text fixes addressed.
@github-actions github-actions bot removed the e-number Waiting on EIP Number assignment label Nov 28, 2022
@poojaranjan poojaranjan mentioned this pull request Nov 29, 2022
Closed
SamWilsn
SamWilsn reviewed Dec 1, 2022
View reviewed changes
EIPS/eip-6059.md

An NFT can be owned by a single other NFT, but can in turn have a number of NFTs that it owns. This proposal establishes the framework for the parent-child relationships of NFTs. A parent token is the one that owns another token. A child token is the token that is owned by another token. A token can be both a parent and child at the same time. Child tokens of a given tokens can be fully managed by the parent token's owner, but can be proposed by anyone.

```mermaid
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this'll render properly on eips.ethereum.org. Something to check once merged.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have our doubts too but let's give a try. If not we'll replace it for another format.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @SamWilsn, just a heads up for the future: this didn't render properly, so we had to update it with pngs.

EIPS/eip-6059.md Outdated Show resolved Hide resolved
EIPS/eip-6059.md Outdated

The process of nesting an NFT into another is functionally identical to sending it to another user. The process of sending a token out of another one involves issuing a transaction from the EOA owning the parent token.

An NFT can be owned by a single other NFT, but can in turn have a number of NFTs that it owns. This proposal establishes the framework for the parent-child relationships of NFTs. A parent token is the one that owns another token. A child token is the token that is owned by another token. A token can be both a parent and child at the same time. Child tokens of a given tokens can be fully managed by the parent token's owner, but can be proposed by anyone.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does "proposed" mean in this context?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea of the propose-accept pattern is that anyone can send (propose) an NFT to yours, but you're free to accept, reject or ignore it.
Maybe "send" is clearer?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think propose is a good term to be used here, but we can explain it in a bit more detail 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The term is fine, but it isn't defined before this point. As someone whose read EIP-721 and EIP-165 (from the requires header), "propose" doesn't really mean anything to me. You should define it in this EIP, or add the EIP with the definition to the requires header.

@steven2308 @SamWilsn
Update EIPS/eip-6059.md
4c06dc1 
Uses "account" instead of "EOA"

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
SamWilsn
SamWilsn reviewed Dec 13, 2022
View reviewed changes
Copy link
Contributor

@SamWilsn SamWilsn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is almost ready to be merged as a draft. Just need to sort out the three comments.

EIPS/eip-6059.md Outdated Show resolved Hide resolved
EIPS/eip-6059.md Outdated Show resolved Hide resolved
EIPS/eip-6059.md Outdated

The process of nesting an NFT into another is functionally identical to sending it to another user. The process of sending a token out of another one involves issuing a transaction from the EOA owning the parent token.

An NFT can be owned by a single other NFT, but can in turn have a number of NFTs that it owns. This proposal establishes the framework for the parent-child relationships of NFTs. A parent token is the one that owns another token. A child token is the token that is owned by another token. A token can be both a parent and child at the same time. Child tokens of a given tokens can be fully managed by the parent token's owner, but can be proposed by anyone.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The term is fine, but it isn't defined before this point. As someone whose read EIP-721 and EIP-165 (from the requires header), "propose" doesn't really mean anything to me. You should define it in this EIP, or add the EIP with the definition to the requires header.

@poojaranjan poojaranjan mentioned this pull request Dec 13, 2022
Closed
@steven2308 @SamWilsn
Apply grammar suggestions from code review
6be6e58 
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
@Pandapip1 Pandapip1 changed the title Propose Parent-Governed Nestable Non-Fungible Tokens standard Add EIP-6059: Parent-Governed Nestable Non-Fungible Tokens standard Dec 13, 2022
Pandapip1
Pandapip1 approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@Pandapip1 Pandapip1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this works as a draft. It's a bit long, but it can be trimmed down later.

@eth-bot eth-bot enabled auto-merge (squash) December 13, 2022 18:29
@ThunderDeliverer ThunderDeliverer marked this pull request as draft December 15, 2022 09:17
auto-merge was automatically disabled December 15, 2022 09:17

Pull request was converted to draft

@ThunderDeliverer ThunderDeliverer marked this pull request as ready for review December 15, 2022 09:17
@eth-bot eth-bot enabled auto-merge (squash) December 15, 2022 09:18
@eth-bot eth-bot merged commit 55b5fc2 into ethereum:master Dec 15, 2022
Woodpile37 added a commit to Woodpile37/EIPs that referenced this pull request Nov 11, 2023
@Woodpile37
build(deps-dev): bump axios from 1.5.1 to 1.6.1 in /assets/eip-7007 (#…
021cd0a 
…190)

Bumps [axios](https://github.com/axios/axios) from 1.5.1 to 1.6.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/axios/axios/releases">axios's
releases</a>.</em></p>
<blockquote>
<h2>Release v1.6.1</h2>
<h2>Release notes:</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>formdata:</strong> fixed content-type header normalization
for non-standard browser environments; (<a
href="https://redirect.github.com/axios/axios/issues/6056">#6056</a>)
(<a
href="https://github.com/axios/axios/commit/dd465ab22bbfa262c6567be6574bf46a057d5288">dd465ab</a>)</li>
<li><strong>platform:</strong> fixed emulated browser detection in
node.js environment; (<a
href="https://redirect.github.com/axios/axios/issues/6055">#6055</a>)
(<a
href="https://github.com/axios/axios/commit/3dc8369e505e32a4e12c22f154c55fd63ac67fbb">3dc8369</a>)</li>
</ul>
<h3>Contributors to this release</h3>
<ul>
<li><!-- raw HTML omitted --> <a
href="https://github.com/DigitalBrainJS" title="+432/-65
([ethereum#6059](axios/axios#6059)
[ethereum#6056](axios/axios#6056)
[ethereum#6055](axios/axios#6055) )">Dmitriy
Mozgovoy</a></li>
<li><!-- raw HTML omitted --> <a href="https://github.com/meyfa"
title="+5/-2 ([ethereum#5835](axios/axios#5835)
)">Fabian Meyer</a></li>
</ul>
<h2>Release v1.6.0</h2>
<h2>Release notes:</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>CSRF:</strong> fixed CSRF vulnerability CVE-2023-45857 (<a
href="https://redirect.github.com/axios/axios/issues/6028">#6028</a>)
(<a
href="https://github.com/axios/axios/commit/96ee232bd3ee4de2e657333d4d2191cd389e14d0">96ee232</a>)</li>
<li><strong>dns:</strong> fixed lookup function decorator to work
properly in node v20; (<a
href="https://redirect.github.com/axios/axios/issues/6011">#6011</a>)
(<a
href="https://github.com/axios/axios/commit/5aaff532a6b820bb9ab6a8cd0f77131b47e2adb8">5aaff53</a>)</li>
<li><strong>types:</strong> fix AxiosHeaders types; (<a
href="https://redirect.github.com/axios/axios/issues/5931">#5931</a>)
(<a
href="https://github.com/axios/axios/commit/a1c8ad008b3c13d53e135bbd0862587fb9d3fc09">a1c8ad0</a>)</li>
</ul>
<h3>PRs</h3>
<ul>
<li>CVE 2023 45857 ( <a
href="https://api.github.com/repos/axios/axios/pulls/6028">#6028</a>
)</li>
</ul>
<pre><code>
⚠️ Critical vulnerability fix. See
https://security.snyk.io/vuln/SNYK-JS-AXIOS-6032459
</code></pre>
<h3>Contributors to this release</h3>
<ul>
<li><!-- raw HTML omitted --> <a
href="https://github.com/DigitalBrainJS" title="+449/-114
([ethereum#6032](axios/axios#6032)
[ethereum#6021](axios/axios#6021)
[ethereum#6011](axios/axios#6011)
[ethereum#5932](axios/axios#5932)
[ethereum#5931](axios/axios#5931) )">Dmitriy
Mozgovoy</a></li>
<li><!-- raw HTML omitted --> <a
href="https://github.com/valentin-panov" title="+4/-4
([ethereum#6028](axios/axios#6028) )">Valentin
Panov</a></li>
<li><!-- raw HTML omitted --> <a href="https://github.com/therealrinku"
title="+1/-1 ([ethereum#5889](axios/axios#5889)
)">Rinku Chaudhari</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/axios/axios/blob/v1.x/CHANGELOG.md">axios's
changelog</a>.</em></p>
<blockquote>
<h2><a
href="https://github.com/axios/axios/compare/v1.6.0...v1.6.1">1.6.1</a>
(2023-11-08)</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>formdata:</strong> fixed content-type header normalization
for non-standard browser environments; (<a
href="https://redirect.github.com/axios/axios/issues/6056">#6056</a>)
(<a
href="https://github.com/axios/axios/commit/dd465ab22bbfa262c6567be6574bf46a057d5288">dd465ab</a>)</li>
<li><strong>platform:</strong> fixed emulated browser detection in
node.js environment; (<a
href="https://redirect.github.com/axios/axios/issues/6055">#6055</a>)
(<a
href="https://github.com/axios/axios/commit/3dc8369e505e32a4e12c22f154c55fd63ac67fbb">3dc8369</a>)</li>
</ul>
<h3>Contributors to this release</h3>
<ul>
<li><!-- raw HTML omitted --> <a
href="https://github.com/DigitalBrainJS" title="+432/-65
([ethereum#6059](axios/axios#6059)
[ethereum#6056](axios/axios#6056)
[ethereum#6055](axios/axios#6055) )">Dmitriy
Mozgovoy</a></li>
<li><!-- raw HTML omitted --> <a href="https://github.com/meyfa"
title="+5/-2 ([ethereum#5835](axios/axios#5835)
)">Fabian Meyer</a></li>
</ul>
<h1><a
href="https://github.com/axios/axios/compare/v1.5.1...v1.6.0">1.6.0</a>
(2023-10-26)</h1>
<h3>Bug Fixes</h3>
<ul>
<li><strong>CSRF:</strong> fixed CSRF vulnerability CVE-2023-45857 (<a
href="https://redirect.github.com/axios/axios/issues/6028">#6028</a>)
(<a
href="https://github.com/axios/axios/commit/96ee232bd3ee4de2e657333d4d2191cd389e14d0">96ee232</a>)</li>
<li><strong>dns:</strong> fixed lookup function decorator to work
properly in node v20; (<a
href="https://redirect.github.com/axios/axios/issues/6011">#6011</a>)
(<a
href="https://github.com/axios/axios/commit/5aaff532a6b820bb9ab6a8cd0f77131b47e2adb8">5aaff53</a>)</li>
<li><strong>types:</strong> fix AxiosHeaders types; (<a
href="https://redirect.github.com/axios/axios/issues/5931">#5931</a>)
(<a
href="https://github.com/axios/axios/commit/a1c8ad008b3c13d53e135bbd0862587fb9d3fc09">a1c8ad0</a>)</li>
</ul>
<h3>PRs</h3>
<ul>
<li>CVE 2023 45857 ( <a
href="https://api.github.com/repos/axios/axios/pulls/6028">#6028</a>
)</li>
</ul>
<pre><code>
⚠️ Critical vulnerability fix. See
https://security.snyk.io/vuln/SNYK-JS-AXIOS-6032459
</code></pre>
<h3>Contributors to this release</h3>
<ul>
<li><!-- raw HTML omitted --> <a
href="https://github.com/DigitalBrainJS" title="+449/-114
([ethereum#6032](axios/axios#6032)
[ethereum#6021](axios/axios#6021)
[ethereum#6011](axios/axios#6011)
[ethereum#5932](axios/axios#5932)
[ethereum#5931](axios/axios#5931) )">Dmitriy
Mozgovoy</a></li>
<li><!-- raw HTML omitted --> <a
href="https://github.com/valentin-panov" title="+4/-4
([ethereum#6028](axios/axios#6028) )">Valentin
Panov</a></li>
<li><!-- raw HTML omitted --> <a href="https://github.com/therealrinku"
title="+1/-1 ([ethereum#5889](axios/axios#5889)
)">Rinku Chaudhari</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/axios/axios/commit/f6d2cf9763bfa124f15c2dc6a5d5d5d9d3e26169"><code>f6d2cf9</code></a>
chore(ci): fix publish action content permission; (<a
href="https://redirect.github.com/axios/axios/issues/6061">#6061</a>)</li>
<li><a
href="https://github.com/axios/axios/commit/a22f4b918a71a4d4caa57ff23d8247eac93765de"><code>a22f4b9</code></a>
chore(release): v1.6.1 (<a
href="https://redirect.github.com/axios/axios/issues/6060">#6060</a>)</li>
<li><a
href="https://github.com/axios/axios/commit/cb8bb2beb215a94a29f19b0d66ab05d32b390230"><code>cb8bb2b</code></a>
chore(ci): Publish to NPM with provenance (<a
href="https://redirect.github.com/axios/axios/issues/5835">#5835</a>)</li>
<li><a
href="https://github.com/axios/axios/commit/37cbf9214a1140d25c2c1a5ff097666c96721d6a"><code>37cbf92</code></a>
chore(ci): added labeling and notification for published PRs; (<a
href="https://redirect.github.com/axios/axios/issues/6059">#6059</a>)</li>
<li><a
href="https://github.com/axios/axios/commit/dd465ab22bbfa262c6567be6574bf46a057d5288"><code>dd465ab</code></a>
fix(formdata): fixed content-type header normalization for non-standard
brows...</li>
<li><a
href="https://github.com/axios/axios/commit/3dc8369e505e32a4e12c22f154c55fd63ac67fbb"><code>3dc8369</code></a>
fix(platform): fixed emulated browser detection in node.js environment;
(<a
href="https://redirect.github.com/axios/axios/issues/6055">#6055</a>)</li>
<li><a
href="https://github.com/axios/axios/commit/f7adacdbaa569281253c8cfc623ad3f4dc909c60"><code>f7adacd</code></a>
chore(release): v1.6.0 (<a
href="https://redirect.github.com/axios/axios/issues/6031">#6031</a>)</li>
<li><a
href="https://github.com/axios/axios/commit/9917e67cbb6c157382863bad8c741de58e3f3c2b"><code>9917e67</code></a>
chore(ci): fix release-it arg; (<a
href="https://redirect.github.com/axios/axios/issues/6032">#6032</a>)</li>
<li><a
href="https://github.com/axios/axios/commit/96ee232bd3ee4de2e657333d4d2191cd389e14d0"><code>96ee232</code></a>
fix(CSRF): fixed CSRF vulnerability CVE-2023-45857 (<a
href="https://redirect.github.com/axios/axios/issues/6028">#6028</a>)</li>
<li><a
href="https://github.com/axios/axios/commit/7d45ab2e2ad6e59f5475e39afd4b286b1f393fc0"><code>7d45ab2</code></a>
chore(tests): fixed tests to pass in node v19 and v20 with
<code>keep-alive</code> enabl...</li>
<li>Additional commits viewable in <a
href="https://github.com/axios/axios/compare/v1.5.1...v1.6.1">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=axios&package-manager=npm_and_yarn&previous-version=1.5.1&new-version=1.6.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the
[Security Alerts
page](https://github.com/Woodpile37/EIPs/network/alerts).

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steven2308 steven2308 steven2308 left review comments

@SamWilsn SamWilsn SamWilsn left review comments

@Pandapip1 Pandapip1 Pandapip1 approved these changes

@eth-bot eth-bot Awaiting requested review from eth-bot eth-bot is a code owner

Assignees
No one assigned
Labels
c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ThunderDeliverer @eth-bot @steven2308 @Pandapip1 @SamWilsn