Add EIP-6093: Custom errors for commonly-used tokens #6093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-new
ernestognw
changed the title
All tests passed; auto-merging...(pass) eip-6093.md
|
…/OpenZeppelin/EIPs into eip/custom-errors-for-erc-tokens
Pandapip1
changed the title
Pandapip1
reviewed
Dec 7, 2022
Pandapip1
suggested changes
Dec 7, 2022
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
ernestognw
changed the title
ernestognw
commented
Dec 12, 2022
There was a problem hiding this comment.
Hey @Pandapip1, I just updated.
I think we're fine with the common-token thing so far.
Requested your review again 🙂
SamWilsn
reviewed
Dec 13, 2022
| --- | ||
| eip: 6093 | ||
| title: Custom errors for commonly-used tokens | ||
| description: Lists custom errors for common token implementations |
There was a problem hiding this comment.
I think we can expand the description a bit. Maybe:
Suggested change
| description: Lists custom errors for common token implementations | |
| description: Structured custom errors for common tokens (EIP-20, EIP-721, and EIP-1155) |
There was a problem hiding this comment.
Thanks for the suggestion. I'm slightly more biased toward your proposal, but there's a competing comment I've already accepted.
I'll leave it open in case someone else wants to comment on this.
Pandapip1
approved these changes
Dec 13, 2022
eth-bot
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the introduction custom errors in Solidity in v0.8.4, there's now a more expressive and gas-efficient way of reverting changes during a transaction.
Given this new addition, we're proposing a list of standard errors to be used for the standard tokens (ERC20, ERC721, and ERC1155), so the clients and implementers can expect an insightful and structured way from a transaction error.
Discussions at https://ethereum-magicians.org/t/eip-6093-custom-errors-for-erc-tokens/12043