Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-725: Improvements #6103

Merged
merged 7 commits into from
Jan 3, 2023
Merged

Update EIP-725: Improvements #6103

merged 7 commits into from
Jan 3, 2023

Conversation

YamenMerhi
Copy link
Contributor

@YamenMerhi YamenMerhi commented Dec 8, 2022 •
edited
Loading

What does this PR introduce?

On the standard:

  • Adding function selector for ERC725 functions
  • Add an example to use specific notations when calling ERC725 overloaded functions
  • Mark standard as Draft instead of Stagnant
  • Change the terms keys and values to dataKeys and dataValues.
  • Change the term key/value store to data key/value store. (Use key/value store instead of key-value store)
  • Edit Executed event to use bytes4 instead of bytes
  • Overload execute function in ERC725X
  • Modify ContractCreated event to include a bytes32 salt

assets

  • Add a simple implementation of ERC725

@github-actions github-actions bot added c-status Changes a proposal's status s-review This EIP is in Review t-erc labels Dec 8, 2022
@eth-bot
Copy link
Collaborator

eth-bot commented Dec 8, 2022 •
edited
Loading

A critical exception has occurred:
Message: pr 6103 is already merged; quitting
(cc @alita-moore, @mryalamanchi)

frozeman
frozeman previously approved these changes Dec 9, 2022
View reviewed changes
Pandapip1
Pandapip1 suggested changes Dec 13, 2022
View reviewed changes
Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also fix the walidator errors

EIPS/eip-725.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added s-draft This EIP is a Draft and removed s-review This EIP is in Review labels Dec 13, 2022
@poojaranjan poojaranjan mentioned this pull request Dec 13, 2022
Closed
SamWilsn
SamWilsn reviewed Dec 13, 2022
View reviewed changes
EIPS/eip-725.md Outdated Show resolved Hide resolved
EIPS/eip-725.md Outdated Show resolved Hide resolved
EIPS/eip-725.md Outdated Show resolved Hide resolved
EIPS/eip-725.md Outdated Show resolved Hide resolved
EIPS/eip-725.md Outdated Show resolved Hide resolved
EIPS/eip-725.md Outdated Show resolved Hide resolved
SamWilsn
SamWilsn reviewed Dec 13, 2022
View reviewed changes
EIPS/eip-725.md Outdated Show resolved Hide resolved
Pandapip1
Pandapip1 reviewed Dec 13, 2022
View reviewed changes
EIPS/eip-725.md Outdated Show resolved Hide resolved
@YamenMerhi
Copy link
Contributor Author

Just 1 CI Error, anyway to resolve it ? @SamWilsn @Pandapip1
Screen Shot 2022-12-14 at 12 16 04 PM

Pandapip1
Pandapip1 reviewed Dec 14, 2022
View reviewed changes
EIPS/eip-725.md Outdated Show resolved Hide resolved
Pandapip1
Pandapip1 approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@Pandapip1 Pandapip1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (requires approval from one of @frozeman, @tyleryasaka)

@SamWilsn SamWilsn mentioned this pull request Dec 16, 2022
Open
@eth-bot eth-bot enabled auto-merge (squash) January 3, 2023 12:28
@eth-bot eth-bot merged commit 788baf9 into ethereum:master Jan 3, 2023
@Jircs1 Jircs1 mentioned this pull request Nov 26, 2023
Open
@BitcoinOutput BitcoinOutput mentioned this pull request Nov 28, 2023
Open
@jircs jircs mentioned this pull request Mar 22, 2024
Open
@Jircs1 Jircs1 mentioned this pull request Mar 22, 2024
Open
@BitcoinOutput BitcoinOutput mentioned this pull request Mar 22, 2024
Open
@jircs jircs mentioned this pull request Mar 24, 2024
Open
@BitcoinOutput BitcoinOutput mentioned this pull request Mar 25, 2024
Open
@Jircs1 Jircs1 mentioned this pull request Mar 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamWilsn SamWilsn SamWilsn left review comments

@frozeman frozeman frozeman approved these changes

@Pandapip1 Pandapip1 Pandapip1 approved these changes

@eth-bot eth-bot eth-bot approved these changes

Assignees
No one assigned
Labels
c-status Changes a proposal's status s-draft This EIP is a Draft t-erc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@YamenMerhi @eth-bot @frozeman @Pandapip1 @SamWilsn