Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-1328 from Stagnant to Review #6451

Merged
merged 3 commits into from
Feb 7, 2023
Merged

Conversation

pedrouid
Copy link
Contributor

@pedrouid pedrouid commented Feb 6, 2023

This EIP specifies a URI format for WalletConnect v1.0 and v2.0 and it's widely used in production already

@github-actions github-actions bot added c-status Changes a proposal's status s-review This EIP is in Review t-erc labels Feb 6, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Feb 6, 2023

A critical exception has occurred:
Message: pr 6451 is already merged; quitting
(cc @alita-moore, @mryalamanchi)

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Feb 6, 2023
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Feb 6, 2023
@github-actions
Copy link

github-actions bot commented Feb 6, 2023

The commit 0bf7624 (as a parent of a8c34e9) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Feb 6, 2023
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is ready and in production, feel free to open a PR to move to Last Call (then Final.)

@eth-bot eth-bot enabled auto-merge (squash) February 7, 2023 15:20
@eth-bot eth-bot merged commit ca51f64 into ethereum:master Feb 7, 2023
iseriohn pushed a commit to iseriohn/EIP-NFT-Rights-Management that referenced this pull request Feb 16, 2023
* Update eip-1328.md

* Update eip-1328.md

* Update eip-1328.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-status Changes a proposal's status s-review This EIP is in Review t-erc w-ci Waiting on CI to pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants