Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose Minimalistic Souldbound Extension for Non-Fungible Tokens #6454

Merged
merged 10 commits into from
Feb 7, 2023

Conversation

ThunderDeliverer
Copy link
Contributor

This EIP draft proposal includes RMRK team's and F. Sullo's work on developing an NFT standard where an NFT can be prevented to be transferred.

Proposed an interface for Non-Fungible Tokens extension allowing for
them to be non-transferrable.
@github-actions github-actions bot added c-new Creates a brand new proposal e-number Waiting on EIP Number assignment s-draft This EIP is a Draft t-erc w-ci Waiting on CI to pass labels Feb 7, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Feb 7, 2023

All tests passed; auto-merging...

(pass) eip-6454.md

classification
updateEIP
  • passed!

(pass) assets/eip-6454/contracts/ISoulbound.sol

classification
ambiguous
  • file assets/eip-6454/contracts/ISoulbound.sol is associated with EIP 6454; because there are also changes being made to EIPS/eip-6454.md all changes to corresponding assets are also allowed

(pass) assets/eip-6454/contracts/mocks/ERC721SoulboundMock.sol

classification
ambiguous
  • file assets/eip-6454/contracts/mocks/ERC721SoulboundMock.sol is associated with EIP 6454; because there are also changes being made to EIPS/eip-6454.md all changes to corresponding assets are also allowed

(pass) assets/eip-6454/hardhat.config.ts

classification
ambiguous
  • file assets/eip-6454/hardhat.config.ts is associated with EIP 6454; because there are also changes being made to EIPS/eip-6454.md all changes to corresponding assets are also allowed

(pass) assets/eip-6454/package.json

classification
ambiguous
  • file assets/eip-6454/package.json is associated with EIP 6454; because there are also changes being made to EIPS/eip-6454.md all changes to corresponding assets are also allowed

(pass) assets/eip-6454/test/soulbound.ts

classification
ambiguous
  • file assets/eip-6454/test/soulbound.ts is associated with EIP 6454; because there are also changes being made to EIPS/eip-6454.md all changes to corresponding assets are also allowed

Assigned the EIP number based on the PR number.
@github-actions github-actions bot removed the e-number Waiting on EIP Number assignment label Feb 7, 2023
@github-actions
Copy link

github-actions bot commented Feb 7, 2023

The commit a6c701d (as a parent of 61a0a4c) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Feb 7, 2023
EIPS/eip-6454.md Outdated

## Backwards Compatibility

The Emotable token standard is fully compatible with [EIP-721](./eip-721.md) and with the robust tooling available for implementations of EIP-721 as well as with the existing EIP-721 infrastructure.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emotable?

SamWilsn
SamWilsn previously approved these changes Feb 7, 2023
@eth-bot eth-bot enabled auto-merge (squash) February 7, 2023 15:27
@eth-bot eth-bot merged commit 71129f0 into ethereum:master Feb 7, 2023
iseriohn pushed a commit to iseriohn/EIP-NFT-Rights-Management that referenced this pull request Feb 16, 2023
…hereum#6454)

* Propose Minimalistic Souldbound Extension for Non-Fungible Tokens

Proposed an interface for Non-Fungible Tokens extension allowing for
them to be non-transferrable.

* Assigned EIP number

Assigned the EIP number based on the PR number.

* Fix author formatting

* Fix links

* Fix typo in the title

* Fix typos

* Fixed the backwards compatimility typo

* Fixed reference link

* Added explanation why we feel that this should be an EIP

* Fix a typo in backwards compatibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants