Add ERC: Signature Aggregation for ERC-4337 #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dror Tirosh <dror.tirosh@gmail.com>
abcoathup
reviewed
Sep 11, 2024
abcoathup
reviewed
Sep 11, 2024
ERCS/erc-4337-agg.md
Outdated
| description: An ERC-4337 improvement to aggregation of all UserOperation signatures in a bundle | ||
| title: Signature Aggregation for Account Abstraction | ||
| author: Vitalik Buterin (@vbuterin), Yoav Weiss (@yoavw), Dror Tirosh (@drortirosh), Shahaf Nacson (@shahafn), Alex Forshtat (@forshtat) | ||
| discussions-to: |
There was a problem hiding this comment.
Please create a discussions topic in Eth Magicians
abcoathup
reviewed
Sep 11, 2024
ERCS/erc-4337-agg.md
Outdated
| @@ -0,0 +1,145 @@ | |||
| --- | |||
| eip: | |||
| description: An ERC-4337 improvement to aggregation of all UserOperation signatures in a bundle | |||
There was a problem hiding this comment.
Description should be after title
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
|
The commit a44004c (as a parent of dcc3d53) contains errors. |
eip-review-bot
changed the title
eip-review-bot
changed the title
|
@abcoathup , what blocks this PR from being closed? |
|
@drortirosh you need an ERC editor to review (I am not an editor). There is only a small number of editors, so it can take some time to get reviewed. In the meantime, ensure that the validator doesn’t raise any errors & fix any issues. There is a fortnightly office hours that you could attend: ethcatherders/EIPIP#360 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're extracting the signature aggregator outside of ERC-4337, so we want first to create a new ERC.
PR for the new ERC is here: #627