Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ERC-7432: Move to Final #646

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ernanirst
Copy link
Contributor

After a year under discussion, and being adopted by multiple projects, we are ready to move ERC-7432 to Final.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Sep 18, 2024

File ERCS/erc-7432.md

Requires 1 more reviewers from @axic, @g11tech, @SamWilsn, @xinbenlv

@@ -4,7 +4,7 @@ title: Non-Fungible Token Roles
description: Role Management for NFTs. Enables accounts to share the utility of NFTs via expirable role assignments.
author: Ernani São Thiago (@ernanirst), Daniel Lima (@karacurt)
discussions-to: https://ethereum-magicians.org/t/eip-7432-non-fungible-token-roles/15298
status: Review
status: Final
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
status: Final
status: Last Call
last-call-deadline: 2024-10-30

You must go through Last Call before you can go to Final. Last Call can be as short as 14 days, but because you can't enable edits from maintainers, it's safer to set a further deadline.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SamWilsn

That's funny, we merged into last call a couple weeks ago. See #609

This was merged to master, right? Am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants