Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix latest_execution_payload_header field in eip4844 state upgrade #3106

Merged
merged 3 commits into from
Nov 17, 2022

Conversation

tbenr
Copy link
Contributor

@tbenr tbenr commented Nov 16, 2022

I think latest_execution_payload_header upgrade has been forgotten

@tbenr tbenr changed the title Fix latest_execution_payload_header field in state upgrade Fix latest_execution_payload_header field in eip4844 state upgrade Nov 16, 2022
@tbenr tbenr changed the title Fix latest_execution_payload_header field in eip4844 state upgrade Fix latest_execution_payload_header field in eip4844 state upgrade Nov 16, 2022
Copy link
Member

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

#3044 is related

specs/eip4844/fork.md Show resolved Hide resolved
specs/eip4844/fork.md Outdated Show resolved Hide resolved
specs/eip4844/fork.md Outdated Show resolved Hide resolved
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
@tbenr
Copy link
Contributor Author

tbenr commented Nov 16, 2022

since #3052 is not yet merged, I was proposing a change to the current version, and let the rebase change the header here accordingly.
Otherwise if we merge this one we have an inconsistency. But depends which one goes in first. If the other goes in first, i'll update the header.

@hwwhww hwwhww added the Deneb was called: eip-4844 label Nov 17, 2022
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tbenr!

I merged @ralexstokes's suggestions and think we can go merge this PR first.

note: also related to #3004

@hwwhww hwwhww merged commit 1623c75 into ethereum:dev Nov 17, 2022
@tbenr tbenr deleted the fix-state-upgrade branch November 17, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deneb was called: eip-4844
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants