Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quiz: staking #10476

Merged
merged 7 commits into from
Jul 19, 2023
Merged

Add quiz: staking #10476

merged 7 commits into from
Jul 19, 2023

Conversation

wackerow
Copy link
Member

@wackerow wackerow commented Jun 16, 2023

Description

  • Adds an eight-question quiz for "staking" topic

Preview

https://ethereumorgwebsitedev01-quizstaking.gatsbyjs.io/en/staking/solo/#quiz

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits review needed 👀 labels Jun 16, 2023
@gatsby-cloud
Copy link

gatsby-cloud bot commented Jun 16, 2023

✅ ethereum-org-website-dev deploy preview ready

Copy link
Contributor

@minimalsm minimalsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🫡 thanks @wackerow

I'm quite concerned that, as far as I can tell, the answer to every question is hidden by default behind an expandable card. Perhaps this speaks more to the design of this page than anything else (thoughts @konopkja?), but this doesn't seem ideal for learnability. If this information is important to solo staking, why is it hidden by default?

I also think there are too many questions here (@konopkja, did we not decide on having a max number of questions enforced in code?).

src/intl/en/learn-quizzes.json Show resolved Hide resolved
src/intl/en/learn-quizzes.json Show resolved Hide resolved
src/data/quizzes/index.ts Outdated Show resolved Hide resolved
src/data/quizzes/index.ts Outdated Show resolved Hide resolved
src/data/quizzes/index.ts Outdated Show resolved Hide resolved
wackerow and others added 3 commits July 6, 2023 01:42
@wackerow wackerow marked this pull request as ready for review July 5, 2023 23:43
@konopkja
Copy link
Contributor

konopkja commented Jul 6, 2023

Nice 🫡 thanks @wackerow

I'm quite concerned that, as far as I can tell, the answer to every question is hidden by default behind an expandable card. Perhaps this speaks more to the design of this page than anything else (thoughts @konopkja?), but this doesn't seem ideal for learnability. If this information is important to solo staking, why is it hidden by default?

I also think there are too many questions here (@konopkja, did we not decide on having a max number of questions enforced in code?).

Those are some good points. The preview deploy isnt working so its hard for me to go through this one but Id say:

Having more complex quiz with up to 10 questions is fine. Given the topic and the currenct experience of doing 5 question i think its alright to occasionally have few more questions.

All questions being collapsed - this is also interesting, yeah i think it speaks about the focus of this quiz perhaps aiming more towards solo stakers than other forms of staking or general info on the topic.

I think the focus should be reflected in the title of the quiz to align expectations or maybe reevaluate some of the questions to make it broader.

@wackerow
Copy link
Member Author

wackerow commented Jul 6, 2023

Ok cool... updated this to Solo Staking per suggestion. Also removed one question where the answer wasn't covered in the page, which brings this to 7 questions... I'll debug the preview deploy

@minimalsm
Copy link
Contributor

@konopkja preview deploy is working

@konopkja
Copy link
Contributor

@konopkja preview deploy is working

is it working for you? when i click on https://ethereumorgwebsitedev01-quizstaking.gatsbyjs.io/en/staking/solo/ the page turns blank

@wackerow
Copy link
Member Author

Hm.. yeah, I'm getting the same blank screen bug.. I'll investigate

@corwintines corwintines merged commit d8f7e64 into dev Jul 19, 2023
3 of 4 checks passed
@corwintines corwintines deleted the quiz-staking branch July 19, 2023 17:37
This was referenced Jul 19, 2023
@pettinarip pettinarip mentioned this pull request Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants