test: Improve out-of-buffer detection in EOF tests #958
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In EOF validation tests, move the container to new heap-allocated buffer of exact size to easily find out-of-buffer reads with address sanitizer.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #958 +/- ##
=======================================
Coverage 94.29% 94.30%
=======================================
Files 143 143
Lines 16138 16142 +4
=======================================
+ Hits 15218 15222 +4
Misses 920 920
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gumb0
reviewed
Jul 26, 2024
| @@ -110,9 +110,17 @@ void eof_validation::TearDown() | |||
| for (size_t i = 0; i < test_cases.size(); ++i) | |||
| { | |||
| const auto& test_case = test_cases[i]; | |||
| EXPECT_EQ(evmone::validate_eof(rev, test_case.kind, test_case.container), test_case.error) | |||
|
|
|||
| // Move the container to new heap-allocated buffer of exact size | |||
There was a problem hiding this comment.
Wouldn't test_case.container.shrink_to_fit() achieve the same?
There was a problem hiding this comment.
Not for std::string where there is SSO and additional NULL terminator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In EOF validation tests, move the container to new heap-allocated buffer of exact size to easily find out-of-buffer reads with address sanitizer.