Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old & copied SHA-3 code and misleading reference to SHA-3 instead of Keccak-256 #2241

Closed
jimenezrick opened this issue Feb 21, 2016 · 1 comment

Comments

@jimenezrick
Copy link
Contributor

This blog explains the issue: https://medium.com/@ConsenSys/are-you-really-using-sha-3-or-old-code-c5df31ad2b0. Ethereum uses Keccak-256, not SHA-3, which was standardized afterwards.

I could myself prepare a PR with this improvements:

obscuren added a commit that referenced this issue Feb 24, 2016
Closes #2241: Use Keccak-256 from golang.org/x/crypto/sha3 and mention explicitly
@karalabe
Copy link
Member

Fixed per your PR.

maoueh pushed a commit to streamingfast/go-ethereum that referenced this issue Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants