We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This blog explains the issue: https://medium.com/@ConsenSys/are-you-really-using-sha-3-or-old-code-c5df31ad2b0. Ethereum uses Keccak-256, not SHA-3, which was standardized afterwards.
I could myself prepare a PR with this improvements:
golang.org/x/crypto/sha3
crypto/sha3
The text was updated successfully, but these errors were encountered:
Merge pull request #2242 from jimenezrick/upstream-crypto
483feb0
Closes #2241: Use Keccak-256 from golang.org/x/crypto/sha3 and mention explicitly
Fixed per your PR.
Sorry, something went wrong.
cmd/utils, core/rawdb, triedb/pathdb: flip hash to path scheme (ether…
10ae179
…eum#2241)
No branches or pull requests
This blog explains the issue: https://medium.com/@ConsenSys/are-you-really-using-sha-3-or-old-code-c5df31ad2b0. Ethereum uses Keccak-256, not SHA-3, which was standardized afterwards.
I could myself prepare a PR with this improvements:
golang.org/x/crypto/sha3
with a small patch to expose Keccak-256: https://github.com/jimenezrick/crypto/commit/8802e1c340c41c8d290e6315609cfbcbdf1b6229 (this thin fork could be hosted in the Ethereum Github obviously)crypto/sha3
gives some extra performance, tested running go test benchmark.The text was updated successfully, but these errors were encountered: