RPC

[frozeman]

In this thread i will add a comment per bug, as this are mostly minor issues.

[frozeman]

1
eth_accounts returns an empty array and eth_coinbase "0x"

[frozeman]

2

• eth_getBalance
• eth_newBlockFilter

should return an error when no/wrong parameter(s) are passed like a number instead of HEX etc.

{"error":{"code":-32602,"message":"INVALID_PARAMS: Invalid method parameters (invalid name and/or type)"},"id":2,"jsonrpc":"2.0"}

message can differ, but the code should stay the same

[frozeman]

3

• eth_newBlockFilter
• eth_newFilter
• shh_newFilter
• eth_uninstallFilter
• shh_uninstallFilter
• web3_sha3

should return error code -32602, but it returns -32603:

Please return an error as follows:

{"error":{"code":-32602,"message":"INVALID_PARAMS: Invalid method parameters (invalid name and/or type)"},"id":2,"jsonrpc":"2.0"}

[frozeman]

4

• shh_newFilter

returns number not HEX

[frozeman]

5
Timeout created filter and auto uninstall them after 10min of no shh_getFilterChanges, eth_getFilterChanges, eth_getFilterLogs or shh_getMessages requests came in.
(prevent filter memory leak)

[frozeman]

6
CPP allows reusing of filter IDs, means when i uninstall a filter the id is free again and will be reused for the next installed filter. Im not sure if thats better or worse, please lets discuss this. But imagine if a lot of dapps install filter and uninstall them (or they timeout) the ID number will grow rapidly.

[tgerring]

With the exception of item 1, I think most of these issues have been addressed.

@frozeman This situation occurs when the accounts have not been initialised. Can we write the tests to WARN when accounts array is empty and coinbase is nil/zero? We should be able to handle these situations without being explicit errors

[obscuren]

Re-open if there any pending issues left with the RPC