Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p2p/discover: node database followup issues #838

Closed
fjl opened this issue Apr 30, 2015 · 2 comments
Closed

p2p/discover: node database followup issues #838

fjl opened this issue Apr 30, 2015 · 2 comments
Assignees
@karalabe
Labels
type:feature

Comments

@fjl
Copy link
Contributor

fjl commented Apr 30, 2015

The node database implemented in #793 has some issues that need to be resolved:

  • The database manages to pick up the local node (Table.self) under some conditions.
    This should not happen. If the expiration (or the seed query) finds a node with the local ID,
    it should drop it.
  • There needs to be a way to disable the seeding process from the command line.
@obscuren
Copy link
Contributor

@fjl @karalabe update or close please

@karalabe
Copy link
Member

I'll try and sort these out today.

tony-ricciardi pushed a commit to tony-ricciardi/go-ethereum that referenced this issue Jan 20, 2022
@kevjue
changed circleci celo-monorepo branch back to master (ethereum#838)
e667f6b
maoueh pushed a commit to streamingfast/go-ethereum that referenced this issue Jun 9, 2023
@0xsharma
rm : logs used for debugging issue (ethereum#838)
33f09fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karalabe karalabe

Labels
type:feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fjl @karalabe @obscuren