Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth_getWork returns non HEX strings #917

Closed
frozeman opened this issue May 11, 2015 · 1 comment
Closed

eth_getWork returns non HEX strings #917

frozeman opened this issue May 11, 2015 · 1 comment
Labels
Milestone

Comments

@frozeman
Copy link
Contributor

eth_getWork returns non strings for the last two byte arrays, which don't start with 0x:

send:

{jsonrpc: "2.0", method: "eth_getWork", params: [], id: 881}

Result:

{
    "id": 881,
    "jsonrpc": "2.0",
    "result": [
        "0xc2aae9392f94b76bf423389298893b709086763539cc0c280833ed82eff31aaf",
        "9b2baad7528ecec612c5751a6bd525905892d7892e155c3b05e61363154a940b",
        "0eaf4a0bac531d9c14b2398be48ec32f8d0c1708335d89862c7bf91e9a"
    ]
}

The last two return values should start with 0x.
Additionally the last value is not a 32 bytes boundary condition, it has less than 32 bytes (should be padded?)

Please see the specs for details: https://github.com/ethereum/wiki/wiki/JSON-RPC#eth_getwork

@frozeman frozeman added the RPC label May 11, 2015
@frozeman frozeman added this to the Frontier milestone May 11, 2015
tgerring added a commit to tgerring/go-ethereum that referenced this issue May 11, 2015
Ensures that the Get Work results are a consistent length. Closes ethereum#917
@tgerring
Copy link
Contributor

Fix to remote agent miner made in 8e77f81

tony-ricciardi pushed a commit to tony-ricciardi/go-ethereum that referenced this issue Jan 20, 2022
* adds ledger ECDSA proof of possession

* improves flow without a ledger flag

* lint

* updates comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants