p2p/enode: improve IPv6 support, add ENR text representation #19663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds entry types for "ip6", "udp6", "tcp6" keys. The IP type stays around because removing it would break a lot of code and force everyone to care about the distinction. I also added a Signature method for completeness' sake.
LocalNode predicts the local node's UDP endpoint and updates the record. This change makes it predict IPv4 and IPv6 endpoints separately since they can now be in the record at the same time.
This allows passing base64-encoded node records to all the places that previously accepted enode:// URLs. The URL format is still supported.
...and return the base64 record in NodeInfo.
gballet
approved these changes
Jun 6, 2019
| @@ -747,9 +747,9 @@ func requestExpiredMessagesLoop() { | |||
| } | |||
|
|
|||
| func extractIDFromEnode(s string) []byte { | |||
| n, err := enode.ParseV4(s) | |||
There was a problem hiding this comment.
Quick reminder to also change the NodeInfo().Enode on line 302
FrankSzendzielarz
approved these changes
Jun 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts p2p/enr and p2p/enode to the final version of EIP-778 (ethereum/EIPs#2097). It also changes all invocations of enode.ParseV4 to enode.Parse, allowing signed ENRs to be set as bootnodes and static peers.