Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/evm: rename json result from receiptRoot to receiptsRoot #26835

Closed
wants to merge 1 commit into from

Conversation

noslav
Copy link

@noslav noslav commented Mar 8, 2023

Looks like these json result fields should be receiptsRoot as per the json tag and everywhere else across the repo

 type ExecutionResult struct {
     StateRoot   common.Hash    `json:"stateRoot"`
     TxRoot      common.Hash    `json:"txRoot"`
     ReceiptRoot common.Hash    `json:"receiptsRoot"`
     LogsHash    common.Hash    `json:"logsHash"`
     Bloom       types.Bloom    `json:"logsBloom"`
     Receipts    types.Receipts `json:"receipts"`
     Rejected    []*rejectedTx  `json:"rejected,omitempty"`
     Difficulty  *big.Int       `json:"currentDifficulty"`
     GasUsed     uint64         `json:"gasUsed"`
     BaseFee     *big.Int       `json:"currentBaseFee,omitempty"`
 }

Signed-off-by: Pranay Valson <pranay.valson@gmail.com>
@holiman
Copy link
Contributor

holiman commented Mar 9, 2023

Thanks for noticing, however, this fix is very incomplete. I will submit a different PR where I regenerate the outputs.

@noslav
Copy link
Author

noslav commented Mar 10, 2023

Thanks for noticing, however, this fix is very incomplete. I will submit a different PR where I regenerate the outputs.

oh thanks for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants