Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/ethapi: avoid using pending for defaults #28784

Merged
merged 3 commits into from
Jan 12, 2024

Conversation

s1na
Copy link
Contributor

@s1na s1na commented Jan 10, 2024

I found these two instances where we are estimating gas and computing the access list for a tx on top of the pending block. Given the discussions around deprecating pending (see #28623 or ethereum/execution-apis#495), we can move away from it internally.

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman added this to the 1.13.11 milestone Jan 12, 2024
@holiman holiman merged commit 407f779 into ethereum:master Jan 12, 2024
1 of 3 checks passed
Dergarcon pushed a commit to specialmechanisms/mev-geth-0x2mev that referenced this pull request Jan 31, 2024
Given the discussions around deprecating pending (see ethereum#28623 or ethereum/execution-apis#495), we can move away from using the pending block internally, and use latest instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants