tree: avoid allocs on paths collection #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
jsign
commented
Jun 29, 2023
Comment on lines
-1545
to
-1547
| childpath := make([]byte, len(path)+1) | ||
| copy(childpath, path) | ||
| childpath[len(path)] = byte(i) |
There was a problem hiding this comment.
This was unfortunately creating the L1545 slice for every 256 children on every InternalNode, even if those children's where empty (or any other case not used in the switch below).
Comment on lines
-1551
to
+1548
| paths = append(paths, childpath) | ||
| paths = append(paths, childNode.stem[:len(path)+1]) |
There was a problem hiding this comment.
In the case of LeafNodes we can reslice the internal stem, so directly avoid allocations at this level.
Comment on lines
+1550
to
1553
| childpath := make([]byte, len(path)+1) | ||
| copy(childpath, path) | ||
| childpath[len(path)] = byte(i) | ||
| list, paths = childNode.collectNonHashedNodes(list, paths, childpath) |
There was a problem hiding this comment.
We only do allocations now in confirmed children that are InternalNodes.
gballet
approved these changes
Jun 29, 2023
jsign
added a commit
that referenced
this pull request
Jul 10, 2023
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
gballet
added a commit
that referenced
this pull request
Jul 10, 2023
…serialization (#354) * don't rely on the commitment in HashedNode change leaf serialization to add the leaf commitment there fix a few tests fix: incorrect size computation caused commitment overwrite fix some unit tests fix the batch unit test * declare paths for serialization * Add CommitmentBytes back in SerializedNode * fixes from replaying * fix: deepsource warnings * tree: avoid memory allocs while collecting paths (#371) Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * pbss: serialized points in uncompressed form (#370) * config: rename serialized point size constant and value to uncompressed form Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * switch to uncompressed serialization Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> --------- Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * tree: transform first layer to hashed nodes after serializing (#372) * tree: after serializing transform first layer to hashed nodes Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * tree: add comment about temporary code Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> --------- Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * tree: make HashedNode non-pointer and fieldless (#373) * tree: make HashedNode non-pointer and fieldless Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * lints Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * hashednode: add panic comment Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * hashednode: add label in toDot Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> --------- Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * rebase fix Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> --------- Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> Co-authored-by: Ignacio Hagopian <jsign.uy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR avoids a big source of allocations detected in our overlay transition benchmark.
I'll explain in the comments.