Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move DeserializeAndVerifyVerkleProof to go-verkle #444

Merged
merged 4 commits into from
Jul 29, 2024

Conversation

gballet
Copy link
Member

@gballet gballet commented Jul 22, 2024

This is a request by Péter, that "the trie namespace isn't cluttered by verkle-specific functions. It makes sense to move it here, since it does not depend on any geth declatations.

@gballet gballet requested a review from jsign July 22, 2024 12:07
Copy link
Collaborator

@jsign jsign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, left some comments for your consideration.

proof_ipa.go Outdated Show resolved Hide resolved
proof_ipa.go Outdated Show resolved Hide resolved
proof_ipa.go Outdated
Comment on lines 607 to 609
// en fait il crée le blockhash contract, mais il met pas les trucs dans le witness
// pourquoi est-ce que c'est triggered maintenant et pourquoi on l'avait pas avant?
// hypothèse: en fait ça marchait pas avant non plus mais on teste que le 2ème bloc
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: write in English.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sacrebleu!

proof_ipa.go Outdated Show resolved Hide resolved
@gballet gballet merged commit 5b4be73 into master Jul 29, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants