Skip to content
This repository has been archived by the owner on Sep 5, 2020. It is now read-only.

Wallet tab losing attributes #1489

Closed
evertonfraga opened this issue Dec 1, 2016 · 2 comments
Closed

Wallet tab losing attributes #1489

evertonfraga opened this issue Dec 1, 2016 · 2 comments
Assignees
Milestone

Comments

@evertonfraga
Copy link
Member

Wallet tab loses its transparent nav bar, tab name and other attributes after a while.

image

Debugged as: Tabs.find({_id: 'wallet'}).fetch()

Damaged wallet tab object:

{
    id : "wallet"
    badge : "22.46 ETH"
    menu : Object
    permissions : Object
    position : 1
    url : "https://wallet.ethereum.org"
}

After hit reload, a healthy wallet tab object:

{
    _id: "wallet"
    appBar : "transparent"
    badge : "22.46 ETH"
    icon : "https://wallet.ethereum.org/wallet-icon.png"
    menu : Object
    name : "Ethereum Wallet"
    nameFull : "Ethereum Wallet"
    permissions : Object
    position : 1
    url : "https://wallet.ethereum.org"
    webviewId : 21
}

System information

Version: `0.8.7`
OS & Version: osx
Node type: `geth`
@evertonfraga evertonfraga self-assigned this Dec 1, 2016
@evertonfraga evertonfraga added this to the 0.9 milestone Dec 1, 2016
@frozeman
Copy link
Contributor

frozeman commented Dec 1, 2016

I guess the issue comes from the way the wallet tab is added. By overwriting the existing one. We definitely need to change that.

Simply add a $set: {...} to the initial wallet adding.

We can talk about that tomorrow

frozeman added a commit that referenced this issue Dec 5, 2016
@evertonfraga evertonfraga modified the milestones: 0.9, 0.9.0 Mar 22, 2017
@lock
Copy link

lock bot commented Mar 31, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked and limited conversation to collaborators Mar 31, 2018
risu-risu pushed a commit to japariyen/japari-mist that referenced this issue May 1, 2022
* updated package elemeents

* fixed max callstack error

* remove URL from error page

* remove URL from error page

* improved url updating

* fix ETH-02-003

* added Blaze._escape to the url.protocol

* use shorthand for `url: url`

* remove function connotation with string.

* updated signatures

* reverted url shorthand

* made preloaders more secure, moved mistAPI

* move pinch zoom blocking

* changed ipc -> ipcRenderer in wrapper

* fixes ETH03-001

* fixes ethereum#1489

* Adding mistMode on the preloader

* fixed mistMode

* fixed sound playing
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants