Light client #1547
Light client #1547
Conversation
|
goes better after #1545 |
| @@ -130,7 +139,7 @@ class EthereumNode extends EventEmitter { | |||
| log.info(`Network: ${this.defaultNetwork}`); | |||
There was a problem hiding this comment.
Would be good to add: log.info(Mode: ${this.defaultMode});
modules/ethereumNode.js
Outdated
|
|
||
| return this.stop() | ||
| .then(() => { | ||
| Windows.loading.show(); | ||
| }) | ||
| .then(() => { | ||
| return this._start(newType || this.type, newNetwork || this.network); | ||
| return this._start(newType || this.type, newNetwork || this.network, newMode || this.nodeMode); |
There was a problem hiding this comment.
Whats this this.nodeMode ? i never see this variable created,shouldnt it be this.mode or something?
|
@frozeman addressed both issues |
modules/ethereumNode.js
Outdated
| @@ -162,7 +163,7 @@ class EthereumNode extends EventEmitter { | |||
| Windows.loading.show(); | |||
| }) | |||
| .then(() => { | |||
| return this._start(newType || this.type, newNetwork || this.network, newMode || this.nodeMode); | |||
| return this._start(newType || this.type(), newNetwork || this.network(), newMode || this.mode()); | |||
There was a problem hiding this comment.
thats not functions, this are get variables.
So just this.mode
There was a problem hiding this comment.
I've tested and this.mode() was returning a value and this.mode wasn't. Are you sure this isn't being made into a function by https://github.com/ethereum/mist/pull/1547/files#diff-409860c680be3333b2089d577f193cf5R65 ?
Will test more this part
|
|
superseded by #3052 |
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
Second PR, focusing on light client issues only.
Review but do not merge before more group discussion.