This repository has been archived by the owner on Sep 5, 2020. It is now read-only.
improve 'METHOD_DENIED' error message #2127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I saw some user log with a possible problem on the error handling. |
frozeman
reviewed
May 8, 2017
modules/ipc/methods/base.js
Outdated
|
|
||
| payload.error = this.ERRORS.METHOD_DENIED; | ||
| const err = this.ERRORS.METHOD_DENIED; | ||
| err.message = err.message.replace(/__method__/, payload.method); |
There was a problem hiding this comment.
i guess a simple string replace '__method__' would be enough here.
There was a problem hiding this comment.
Are we sure we are not modifying the original object?
|
Thanks @frozeman! |
frozeman
approved these changes
Jul 14, 2017
frozeman
pushed a commit
that referenced
this pull request
Jul 24, 2017
* improve 'METHOD_DENIED' error message (#2127) * improve 'METHOD_DENIED' error message * fix * upstream fixes * Swarm additions (#2764) * fixes batch requests on isolated preloaders * added 404 page for not found swarm content * fixed coide climate issues * show custom 404 error only for bzz:// * Error page fixes and build errors (#2780) * fixes batch requests on isolated preloaders * added 404 page for not found swarm content * fixed coide climate issues * show custom 404 error only for bzz:// * fixed borwser.js issue and sound and error pages * trigger travis * trigger travis * adding globals to ESLint whitelist * Small refactor; Fixing 3/4 tests * Adjusting spectron version * ESLint * [Spectron] New fixture server; Fixes 4/4 test. * Wallet shouldn't start Swarm * Wallet shouldn't start Swarm * Adding exception to eslint * Fix wallet preloader issue * Mac release path (#2808) * Adding gitter channel info (#2807) * Add bzz and .eth to urls (#2792) * add .eth * refactor ifs * solve for wallet.ethereum.org * Fixing delay problem
evertonfraga
added a commit
that referenced
this pull request
Sep 22, 2017
* improve 'METHOD_DENIED' error message (#2127) * improve 'METHOD_DENIED' error message * fix * upstream fixes * Swarm additions (#2764) * fixes batch requests on isolated preloaders * added 404 page for not found swarm content * fixed coide climate issues * show custom 404 error only for bzz:// * Error page fixes and build errors (#2780) * fixes batch requests on isolated preloaders * added 404 page for not found swarm content * fixed coide climate issues * show custom 404 error only for bzz:// * fixed borwser.js issue and sound and error pages * trigger travis * trigger travis * adding globals to ESLint whitelist * Small refactor; Fixing 3/4 tests * Adjusting spectron version * ESLint * [Spectron] New fixture server; Fixes 4/4 test. * Wallet shouldn't start Swarm * Wallet shouldn't start Swarm * Adding exception to eslint * Fix wallet preloader issue * Mac release path (#2808) * Adding gitter channel info (#2807) * Add bzz and .eth to urls (#2792) * add .eth * refactor ifs * solve for wallet.ethereum.org * Fixing delay problem * Update README.md (#2829) * Node version field. * Borrowing sentence from truffle's issue template * Complete Albanian translation (#2919) * Nightly backup * Typo fix * Fix formatting * Complete mist.sq.i18n.json * Complete mist.sq.i18n.json * Possible fixes * add menu item list * fix syntax error * Fit in with other translations * Fixing json format (#2946) * Fixing gitter URL (#2948) * Updating geth (#2949) * Update solc 1.4.15 (#2960) * WIP: update solidity to 1.4.12 * Updating solc to 0.4.13 * Updating to solc 0.4.15 * Update copyright year 2016 to 2017 on About page (#3000) Update copyright year 2016 to 2017 on About page * Adds GitHub PR template (#3035) * Revert "Update copyright year 2016 to 2017 on About page" (#3037) * Revert "Adds GitHub PR template (#3035)" This reverts commit ba7a210. * Revert "Update copyright year 2016 to 2017 on About page (#3000)" This reverts commit c8a64f1. * Compiles ES6+ (#3034) * Compiles es6+7 * Optionally skipping gulp tasks * Rearranges deps * Fixing menuItems bug * Transpiles with Babel * Runs dev with Babel * Compiles modules directory * Fixes Swarm template typos (#3048) * Tweaks README for new dev script (#3058) * Update geth binaries to 1.7.0 (#3046) Ethereum to the moon!!! YAY!!!
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test via
menu -> develop -> run tests.Also removes unnecessary
Windowobject.