This repository has been archived by the owner on Sep 5, 2020. It is now read-only.
Auto-generating SHA256 checksums #3291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
It runs sha256 against Mist/EW artifacts and appends them to the release notes if there are any release drafts.
Any helpful background information?
We used to distribute binaries with MD5 checksums. SHA-256 checksums were generated manually until now.
Which code should the reviewer start with?
New dependencies? What are they used for?
No.
Relevant screenshots?
This is what we aim for. We can't ensure what order the builds will finish, so it still requires a little text manipulation at the end, as all builds will print out the table header as well.