Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix encoding of side-effects inside if and ternary in BMC #14216

Merged
merged 1 commit into from
May 15, 2023
Merged

Fix encoding of side-effects inside if and ternary in BMC #14216

merged 1 commit into from
May 15, 2023

Conversation

leonardoalt
Copy link
Member

Fixes #14211

pgebal
pgebal approved these changes May 12, 2023
View reviewed changes
test/libsolidity/smtCheckerTests/control_flow/side_effects_inside_ternary_1.sol
uint x;
uint y = (++x < 3) ? ++x : --x;

assert(y == x); // should hold;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
assert(y == x); // should hold;
assert(y == x); // should hold

@ekpyron ekpyron merged commit 9804085 into develop May 15, 2023
@ekpyron ekpyron deleted the fix_bmc_side_effects_in_statement branch May 15, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgebal pgebal pgebal approved these changes

@ekpyron ekpyron Awaiting requested review from ekpyron

Assignees

@leonardoalt leonardoalt

Labels
None yet
Projects
Solidity Focus Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SMTChecker does not handle increment expression in if statement condition correctly
3 participants
@leonardoalt @pgebal @ekpyron