VM -> EIP-1153 (Transient Storage) Fix: Improve the time complexity of commit by using a journal instead… #1860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of stack of maps this is necessary because created a large call stack, then writing a bunch of keys and having all the calls return could potentially DOS the client
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
holgerd77
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… of stack of maps
this is necessary because creating a large call stack, then writing a bunch of keys and having all the calls return could potentially DOS the client
also this pr removes unused methods
another implementation considered was a stack of maps with checkpoints, instead of merging the maps, but that is easily exploited since there is no difference in gas cost between writing unique keys and writing the same keys. the overhead of maps may not be worth it