Fixed height measurement when wrap_content #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Emil. I'll test this out. |
|
+1 worked for me |
denizmveli
added a commit
that referenced
this pull request
Dec 31, 2013
Merged pull request #16 - Fixed height measurement when wrap_content
|
Excellent - thanks @emilsjolander. Just a heads up given the frequent instability of the gradle plugin, I'm going to make a change to specify 0.7.3 instead of 0.7.+ |
denizmveli
pushed a commit
that referenced
this pull request
Dec 31, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that if the root view of my items in the grid was using
wrap_contentas the height of the view would measure itself to be very large. This happens in the sample app as well if the target/compile sdk version is set to 19.I also took the liberty to update the gradle version used.