Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates gradle plugin version and gradle version to latest #78

Merged
merged 1 commit into from
Apr 6, 2014

Conversation

xrigau
Copy link
Contributor

@xrigau xrigau commented Mar 20, 2014

This allows the project to be imported with the latest Android Studio version (0.5.2).
Also removes duplication between build.gradle files (the repositories closure)

This allows the project to be imported with the latest Android Studio version (0.5.2).
Also removes duplication between build.gradle files
dependencies {
classpath 'com.android.tools.build:gradle:0.8.0'
classpath 'com.android.tools.build:gradle:0.9.+'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@denizmveli is it ok for you to use wildcards here? if not I can change to specify the latest version instead

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer not to have + but I can change this after the merge

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 cheers!

@cesards
Copy link

cesards commented Apr 3, 2014

@xrigau tiu aquesta llibreria l'han abandonat o què? Era la única que tirava guai...

denizmveli added a commit that referenced this pull request Apr 6, 2014
Merged pull request #78 - Updates gradle plugin version and gradle version to latest
@denizmveli denizmveli merged commit 69db9ea into etsy:master Apr 6, 2014
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=http\://services.gradle.org/distributions/gradle-1.10-bin.zip
distributionUrl=http\://services.gradle.org/distributions/gradle-1.10-all.zip

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not gradle-1.11-all.zip ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Android Studio can import the project with both 1.10 & 1.11, but you're right I could have used the latest version

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem - I'll update this

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants