Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Credential Response Encryption policy. #173

Merged
merged 7 commits into from
Mar 30, 2024
Merged

Introduce Credential Response Encryption policy. #173

merged 7 commits into from
Mar 30, 2024

Conversation

dzarras
Copy link
Contributor

@dzarras dzarras commented Mar 22, 2024

Closes #171

@dzarras dzarras requested a review from a team as a code owner March 22, 2024 12:18
babisRoutis
babisRoutis requested changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@babisRoutis babisRoutis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dzarras Can you please tackle the comments?

@vafeini
Copy link
Contributor

vafeini commented Mar 28, 2024

We need the following 2 unit tests to be added:

  • when wallet mandates encrypted responses but issuer does not then excpetion ResponseEncryptionRequiredByWalletButNotSupportedByIssuer is thrown
  • when wallet mandates encrypted responses but no cryptographic can be generated WalletRequiresCredentialResponseEncryptionButNoCryptoMaterialCanBeGenerated is thrown

vafeini
vafeini previously approved these changes Mar 28, 2024
View reviewed changes
babisRoutis
babisRoutis requested changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@babisRoutis babisRoutis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dzarras Can you please implement in this PR the first solution of
#171 (comment)

@dzarras
Copy link
Contributor Author

dzarras commented Mar 29, 2024 •
edited
Loading

@vafeini

We need the following 2 unit tests to be added: when wallet mandates encrypted responses but issuer does not then excpetion ResponseEncryptionRequiredByWalletButNotSupportedByIssuer is thrown when wallet mandates encrypted responses but no cryptographic can be generated WalletRequiresCredentialResponseEncryptionButNoCryptoMaterialCanBeGenerated is thrown

Added.

@dzarras dzarras force-pushed the feat/response-encryption-policy branch from b52d03a to 2e73e6a Compare March 29, 2024 08:08
@dzarras
Copy link
Contributor Author

dzarras commented Mar 29, 2024

@babisRoutis

Can you please implement in this PR the first solution of #171 (comment)

Done. Please check.

@dzarras dzarras added the feature New feature or request label Mar 29, 2024
@babisRoutis babisRoutis merged commit 3220b83 into eu-digital-identity-wallet:main Mar 30, 2024
4 checks passed
@babisRoutis babisRoutis deleted the feat/response-encryption-policy branch March 30, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@babisRoutis babisRoutis babisRoutis approved these changes

@vafeini vafeini vafeini approved these changes

Assignees

@babisRoutis babisRoutis

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow wallet to define its policy about response encryption
3 participants
@dzarras @vafeini @babisRoutis