Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate ProofSigner & BindingKey #231

Merged
merged 8 commits into from
May 27, 2024
Merged

Deprecate ProofSigner & BindingKey #231

merged 8 commits into from
May 27, 2024

Conversation

babisRoutis
Copy link
Contributor

@babisRoutis babisRoutis commented May 27, 2024 •
edited
Loading

This PR

  • Deprecates the name BindingKey favoring the more correct JwtBindingKey
  • Deprecates the ProofSigner
  • Introduces a new sealed hierarchy named PopSigner with a single member PopSigner.Jwt

The usages of ProofSigner have been replaced by PopSigner or PopSigner.Jwt depending on the case.

Closes #232

@babisRoutis babisRoutis requested a review from a team as a code owner May 27, 2024 13:33
@babisRoutis babisRoutis added this to the openid4vci-kt v0.2.4 milestone May 27, 2024
@babisRoutis babisRoutis merged commit 89d09b8 into eu-digital-identity-wallet:main May 27, 2024
3 checks passed
@babisRoutis babisRoutis deleted the feat/improve-proofsigner branch May 27, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vafeini vafeini vafeini left review comments

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
openid4vci-kt v0.3.0
Development

Successfully merging this pull request may close these issues.

Deprecate ProofSigner
2 participants
@babisRoutis @vafeini