-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft 14 #312
Draft
babisRoutis
wants to merge
6
commits into
eu-digital-identity-wallet:main
Choose a base branch
from
niscy-eudiw:draft14
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Draft 14 #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
We need to |
The following change was necessary: Submission outcome has now three possible states: Success (or Issued), Deferred, Failed. sealed interface SubmissionOutcome : java.io.Serializable {
/**
* State that denotes the successful submission of an issuance request
* @param credentials The outcome of the issuance request.
* If the issuance request was a batch request, it will contain the results of each issuance request.
* If it was a single issuance request list will contain only one result.
*/
data class Success(val credentials: List<IssuedCredential>) : SubmissionOutcome
/**
* Credential could not be issued immediately. An identifier is returned from server to be used later on
* to request the credential from issuer's Deferred Credential Endpoint.
*
* @param transactionId A string identifying a Deferred Issuance transaction.
*/
data class Deferred(val transactionId: TransactionId) : SubmissionOutcome
/**
* State that denotes that the credential issuance request has failed
*
* @param error The error that caused the failure of the request
*/
data class Failed(val error: CredentialIssuanceError) : SubmissionOutcome
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #309
Closes #295
Closes #294
Closes #316