Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query for presentation event log #177

Merged
merged 17 commits into from
Jul 26, 2024
Merged

Query for presentation event log #177

merged 17 commits into from
Jul 26, 2024

Conversation

babisRoutis
Copy link
Contributor

@babisRoutis babisRoutis commented Jul 24, 2024 •
edited by dzarras
Loading

This PR adds a new option to the VerifierAPI that would allow the Verifier to obtain a list of events, the event log, for a presentation.

  • Introduce a sealed hierarchy PresentationEvent, to represent notable events
  • Allow the use cases, to publish such events
  • Add a new option to VerifierAPI to allow the retrieval of the event log
  • Add an in memory repo to store such events
  • Add to OpenAPI the new endpoint
  • Consider adding unhappy path events
  • Introduce a timer to remove those events from the repo

Closes #178

@babisRoutis babisRoutis added the feature New feature or request label Jul 24, 2024
@babisRoutis babisRoutis marked this pull request as ready for review July 26, 2024 08:58
@babisRoutis babisRoutis requested a review from a team as a code owner July 26, 2024 08:58
@babisRoutis babisRoutis requested a review from dzarras July 26, 2024 08:59
@babisRoutis
Copy link
Contributor Author

@dzarras I think that it is ready. Please check the OpenAPI addition

@dzarras
Copy link
Contributor

dzarras commented Jul 26, 2024

@babisRoutis Besides the two points above, the PR is ready for merging.

@babisRoutis babisRoutis merged commit f8763f6 into eu-digital-identity-wallet:main Jul 26, 2024
3 checks passed
@babisRoutis babisRoutis deleted the feat/presentation-logs branch July 26, 2024 12:07
@dzarras dzarras removed this from the eudi-web-verifier-endpoint v0.1.4 milestone Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzarras dzarras dzarras left review comments

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow the verifier to query for events related to a presentation transaction
2 participants
@babisRoutis @dzarras