-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Portable stories #57
Portable stories #57
Conversation
For now only proof of concept that works for the atlas story Still need to fix the layout Had to use old version of remark-directive to be compatible with nuxt/content.
Opted to remove the Panel component again and to manually separate the content into chapters instead. This gives more control.
so we don't port all content through webpack This gave problems with standalone HTML stuff
@@ -13,7 +13,9 @@ | |||
"dependencies": { | |||
"@nuxt/content": "^1.14.0", | |||
"core-js": "^3.15.1", | |||
"nuxt": "^2.15.7" | |||
"nuxt": "^2.15.7", | |||
"remark-directive": "^1.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we also need a dependency list for those pro users, especially given the fancy handling you made with the portable format of these stories. We can make a developer readme later and list the packages used to handle these markdown files in such an elegant way (e.g. remark-directive, remark-sectionize), with some further explanation and links to the detailed documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean a bit of explanation for how it works? I wanted to write some of those things in the blog post I'm working on. Perhaps we can reuse it.
Splendid job @Peter9192 . Really a big leap for the Storyboards. I only got some minor comments. Look forward to the upcoming changes! |
@geek-yang can you approve please? |
relates to #58