Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portable stories #57

Merged
merged 22 commits into from
Jan 26, 2022
Merged

Portable stories #57

merged 22 commits into from
Jan 26, 2022

Conversation

Peter9192
Copy link
Member

@Peter9192 Peter9192 commented Jan 13, 2022

relates to #58

  • Move images and other content from /static to /content

README.md Show resolved Hide resolved
@@ -13,7 +13,9 @@
"dependencies": {
"@nuxt/content": "^1.14.0",
"core-js": "^3.15.1",
"nuxt": "^2.15.7"
"nuxt": "^2.15.7",
"remark-directive": "^1.0.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we also need a dependency list for those pro users, especially given the fancy handling you made with the portable format of these stories. We can make a developer readme later and list the packages used to handle these markdown files in such an elegant way (e.g. remark-directive, remark-sectionize), with some further explanation and links to the detailed documentation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean a bit of explanation for how it works? I wanted to write some of those things in the blog post I'm working on. Perhaps we can reuse it.

@geek-yang
Copy link
Member

Splendid job @Peter9192 . Really a big leap for the Storyboards. I only got some minor comments. Look forward to the upcoming changes!

@Peter9192 Peter9192 marked this pull request as ready for review January 25, 2022 10:08
@Peter9192
Copy link
Member Author

@geek-yang can you approve please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants