Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createRequest ignores path option #68

Closed
aaronjameslang opened this issue Aug 4, 2015 · 4 comments
Closed

createRequest ignores path option #68

aaronjameslang opened this issue Aug 4, 2015 · 4 comments

Comments

@aaronjameslang
Copy link
Contributor

If a path but no url is supplied to createRequest, the path is ignored.

This should be an easy fix, I'll submit a pull request when I've fixed it.

@aaronjameslang
Copy link
Contributor Author

Pull request: #69

@howardabrams
Copy link
Collaborator

Guess we can close this now, eh? ;-)

@aaronjameslang
Copy link
Contributor Author

Yeh, thanks. Who's responsible for closing issues? Should I have done it
when the pull request was accepted?

On 28 October 2015 at 05:12, Howard Abrams notifications@github.com wrote:

Guess we can close this now, eh? ;-)


Reply to this email directly or view it on GitHub
#68 (comment)
.

@howardabrams
Copy link
Collaborator

Sure! Go for it. Thanks again for helping.

On Oct 29, 2015, at 2:58 AM, Aaron J. Lang notifications@github.com wrote:

Yeh, thanks. Who's responsible for closing issues? Should I have done it
when the pull request was accepted?

On 28 October 2015 at 05:12, Howard Abrams notifications@github.com wrote:

Guess we can close this now, eh? ;-)


Reply to this email directly or view it on GitHub
#68 (comment)
.


Reply to this email directly or view it on GitHub #68 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants