Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added baseUrl property #150

Merged
merged 1 commit into from
Oct 11, 2017
Merged

Added baseUrl property #150

merged 1 commit into from
Oct 11, 2017

Conversation

terrencezli
Copy link

Added the baseUrl property to the request object.

http://expressjs.com/en/api.html#req.baseUrl

Included test cases similar to originalUrl. Similarly to request.originalUrl, request.baseUrl does not provide validation.

@terrencezli terrencezli changed the title Added baseUrl property object Added baseUrl property Oct 10, 2017
@howardabrams howardabrams merged commit 859ede7 into eugef:master Oct 11, 2017
@howardabrams
Copy link
Collaborator

Looks good. Thanks.

@terrencezli terrencezli deleted the add-baseurl branch October 11, 2017 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants