Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library to read Matlab files #74

Open
gmaze opened this issue Nov 9, 2021 · 1 comment
Open

Library to read Matlab files #74

gmaze opened this issue Nov 9, 2021 · 1 comment
Labels
invalid This doesn't seem right priority-low Low priority for next release refactoring improve the design, structure, and/or implementation

Comments

@gmaze
Copy link
Member

gmaze commented Nov 9, 2021

I see that pyowc is using 2 libraries to read Matlab mat files:

The former is used only once, the latter basically everywhere else.

I see from #52 that pymatreader was added to fix #30 , so in fact we can't get rid of this dependency

So why using 2 dependencies for the same task ?

Should pyowc use only 1 reader ? pymatreader only

ps: This is not considering the fact that all external data should be accessible in other formats than Matlab (eg: #53)

@gmaze gmaze added invalid This doesn't seem right refactoring improve the design, structure, and/or implementation labels Nov 9, 2021
@kamwal
Copy link
Contributor

kamwal commented Oct 25, 2022

the pymatreader has been used to be able to read some older versions of the Matlab files.
I think that yes the pymatreader might be used in the code instead of scipy.io

@kamwal kamwal added Priority_low priority-low Low priority for next release and removed Priority_low labels Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right priority-low Low priority for next release refactoring improve the design, structure, and/or implementation
Projects
None yet
Development

No branches or pull requests

2 participants