Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task or Issue
Issue 1 - There was problem in reading Argo reference data issues/30, resulting terminating the code
Issue 2 - In the plots-diagnostics function of python code there is available only uncalibrated version of sal_anom_plot, the calibrated version of this plot was missing. issues/48
Issue 3 - There was an issue in extracting elevation data from t_base.int issues/9
Issue 4 - The python function (scipy.io. loadmat) to read matlab WMO.mat data was not reading data with version 7.4. this issue has not been previously detected during UAT
Task 1 - Added chart of the most updated plot dependency diagram of pyowc punctions
Improvement 1 - Added improvement of corrected size of plots in saving data to .eps issues/38
Symptom
Issue 1 - There was Error message of no data found for analysis
Issue 2 - Lack of the calibrated version of sal_anom_plot
Issue 3 - There was error message preventing further calulation in update salinity mapping.
Issue 4 - In update salinity maping function there was used relatively less referenced data to analysis compared with matlab version.
Problem
Issue 1 - The problem was that directory string with location of Argo ref. data was not witten, the function os.path.sep.join did not combined parts of string data properly.
Issue 2 - calibrated sal_anom_plot plot was ommited during writing the code
Issue 3 - The problem was a missing part of code that would wrap the elevation data with wrapped londitudes
Issue 4 - Less referenced data used in calulations led to less effective comparison with Argo float data and uncertaintnes
Solution
Issue 1 - The joining of parts of streeng with data directory was made using plus symbol "+" between each part of string.
Issue 2 - The calibrated version of plot was added to plot_diagnostic.py and dashboard.py
Issue 3 - The code including wrapping data was included
Issue 4 - The scipy.io. loadmat function was replaced by pymatreader.read_mat