Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CTDRefDataFetcher to argopy.related #300

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Conversation

gmaze
Copy link
Member

@gmaze gmaze commented Oct 9, 2023

The :class:CTDRefDataFetcher is badly located in the data_fetchers private sub-module, let's refactor in the more appropriate related public sub-module.

@gmaze gmaze added the internals Internal machinery label Oct 9, 2023
Clean-up dat_fetchers __init__ because all classes have the same name as sub-modules
Copy link

github-actions bot commented Jan 7, 2024

This pull request was marked as staled automatically because it has not seen any activity in 90 days

@github-actions github-actions bot added the stale No activity over the last 90 days label Jan 7, 2024
@gmaze
Copy link
Member Author

gmaze commented Apr 12, 2024

I'm not sure this PR could go through, the current design makes very difficult to avoid circularity
moving back to a draft

@gmaze gmaze marked this pull request as draft April 12, 2024 10:47
@github-actions github-actions bot removed the stale No activity over the last 90 days label Apr 13, 2024
Copy link

This pull request was marked as staled automatically because it has not seen any activity in 90 days

@github-actions github-actions bot added the stale No activity over the last 90 days label Jul 12, 2024
@gmaze gmaze self-assigned this Jul 16, 2024
@gmaze gmaze marked this pull request as ready for review July 16, 2024 09:48
@gmaze gmaze removed the stale No activity over the last 90 days label Jul 16, 2024
@gmaze gmaze marked this pull request as draft September 4, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internals Internal machinery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant