Implement other than bgc-2024 branch major breaking refactoring for major release v1.0.0 #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also fix a bug in pyarrow search_params
- fix deprec warning
- sort private _minimal_vlist property
- fix bug with shortcuts in ArgoIndex file and convention - the ArgoIndex now support the "etc/argo-index/argo_aux-profile_index.txt" index file
- start support for more user mode in BGC
- don't remember why these variables were included, not consistant ...
- based on new utility merge_param_with_param_adjusted
- fix bug in to_index data fetcher method whereby the index could differ from the dataset
- fix list of bgc variables to request and their constraints - reduced final checks in to_xarray for bgc to filter_measured - delete filter_points, new filter_measured - filter_measured applies to <PARAM> OR <PARAM>_ADJUSTED
- Add filter_data_mode that really filter the data according to their DATA MODE (previous version was actually merging PARAM and PARAM_ADJUSTED, this is now done by transform_data_mode
Update filter_variables to support BGC
- add postprocessors for BGC
- list_bgc_s_variables, list_bgc_s_parameters - list_radiometry_variables, list_radiometry_parameters - list_core_parameters
This would be a simple mechanism to provide extensions to the argo xarray accessor
- In this sub-module, we shall find all methods/classes that will be used an "extension" to the xarray Argo accessor - The goal is to facilitate the dev of more extensions for new comers - Refactor Canyon-MED in the new 'extensions' submodule
- fix bug whereby user mode was not passed to downstream instances when URI was split
- list_standard_variables now return list for phy or bgc dataset - improve consistency of the "variable" vs "parameter" terms usage - fix bug whereby transforming the dataset according to data mode was not allowing delayed mode only and adjusted only variables in a dataset - improve docstrings - limit use of explicit list of parameters, fall back on using the utility list functions
- describe BGC support for expert and research user modes
- fix bug whereby pressure constraint was on pres_adjusted rather than pres for researcu user mode erddap uri
- fix bugs whereby list of parameters was not created when the list of params was in the args
/home/runner/micromamba/envs/argopy-tests/lib/python3.10/site-packages/fsspec/registry.py:279: UserWarning: Your installed version of s3fs is very old and known to cause severe performance issues, see also dask/dask#10276
- option "ftp" renamed "gdac" - "FTPArgoDataFetcher" renamed "GDACArgoDataFetcher" - GDAC fetchers argument "ftp" renamed "gdac" - "validate_ftp" renamed "validate_gdac" in options.py
removing numpy datetime64 utc warning
improve doctrings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that these changes are listed and marked as deprecated in #388