Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add storybook #140

Merged
merged 6 commits into from
Apr 17, 2021
Merged

feat: add storybook #140

merged 6 commits into from
Apr 17, 2021

Conversation

martinbianchi
Copy link
Contributor

@martinbianchi martinbianchi commented Apr 15, 2021

closes #131

@osdiab I succesfully implemented storybook and create some stories for the Widget and the Generic Button. I do not have access to Vercel but maybe would be a nice idea to use storybook as a preview for the widget

@vercel
Copy link

vercel bot commented Apr 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/everydotorg/donate-button/5wWkVdDHYGmpy1BBfzQMGyup6KN6
✅ Preview: https://donate-button-git-mbianchi-storybook-everydotorg.vercel.app

@osdiab
Copy link
Contributor

osdiab commented Apr 16, 2021

nice! yeah that's a great idea, we can add that in a separate PR.

Copy link
Contributor

@osdiab osdiab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great start!

@osdiab
Copy link
Contributor

osdiab commented Apr 16, 2021

looks like the build got messed up somehow on this PR. debugging.

@osdiab
Copy link
Contributor

osdiab commented Apr 16, 2021

seems to be because storybook uses html-webpack-plugin@4 but the preact app and our hacked together config uses html-webpack-plugin@3. fixing it. this is an argument for #75

@osdiab
Copy link
Contributor

osdiab commented Apr 16, 2021

ugh looks like preact-cli only supports @3 and storybook only supports @4, which are mutually incompatible and causing issues when building. might need to move the storybook to a separate subpackage to make it work.

@osdiab
Copy link
Contributor

osdiab commented Apr 16, 2021

i'm gonna hold off on merging this for now because of the build errors

@osdiab
Copy link
Contributor

osdiab commented Apr 16, 2021

created issue on preact-cli here preactjs/preact-cli#1551

@martinbianchi
Copy link
Contributor Author

martinbianchi commented Apr 16, 2021

@osdiab I checked on my local environment and everything was working fine until I updated the html-webpack-plugin version to the 4.5.2 as you said. So I downgraded the version to the 3.2.0 that it's the version that preact uses and both compilations are working, at least on my local env. Do you think that for the time being is a possible solution to this problem?

@osdiab
Copy link
Contributor

osdiab commented Apr 17, 2021

oh sweet - nice! let's merge it then!

@osdiab osdiab merged commit d53734a into main Apr 17, 2021
@osdiab osdiab deleted the mbianchi/storybook branch April 17, 2021 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow full customization in the demo page
2 participants