Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

feat: support dynamic app db backend flag #1226

Merged
merged 5 commits into from
Aug 5, 2022

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Aug 4, 2022

Build rocksdb enabled binary:

ENABLE_ROCKSDB=true COSMOS_BUILD_OPTIONS=rocksdb make build

Enable app-db-backend in app.config, or use cli flag:ethermintd start --app-db-backend "rocksdb"

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@yihuang yihuang changed the title support dynamic app db backend feat: support dynamic app db backend flag Aug 4, 2022
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Minor comments

CHANGELOG.md Outdated Show resolved Hide resolved
server/start.go Outdated Show resolved Hide resolved
cmd/ethermintd/root.go Outdated Show resolved Hide resolved
server/start.go Outdated Show resolved Hide resolved
server/start.go Show resolved Hide resolved
@fedekunze fedekunze merged commit 7331cd2 into evmos:main Aug 5, 2022
@yihuang yihuang deleted the app-db-backend branch August 5, 2022 13:59
@danburck danburck mentioned this pull request Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants