Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

chore(evm): cleanup EVM files #1582

Merged
merged 2 commits into from
Dec 30, 2022
Merged

chore(evm): cleanup EVM files #1582

merged 2 commits into from
Dec 30, 2022

Conversation

fedekunze
Copy link
Contributor

@fedekunze fedekunze commented Dec 30, 2022

Description

Minor maintenance cleanup of functions within the EVM


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze fedekunze marked this pull request as ready for review December 30, 2022 12:01
@fedekunze fedekunze requested a review from a team as a code owner December 30, 2022 12:01
@fedekunze fedekunze requested review from hanchon and facs95 and removed request for a team December 30, 2022 12:01
@codecov
Copy link

codecov bot commented Dec 30, 2022

Codecov Report

Merging #1582 (dbc29d1) into main (17343e6) will increase coverage by 0.00%.
The diff coverage is 90.09%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1582   +/-   ##
=======================================
  Coverage   68.65%   68.65%           
=======================================
  Files         103      105    +2     
  Lines        9953     9954    +1     
=======================================
+ Hits         6833     6834    +1     
  Misses       2737     2737           
  Partials      383      383           
Impacted Files Coverage Δ
x/evm/keeper/grpc_query.go 85.90% <ø> (ø)
x/evm/statedb/config.go 100.00% <ø> (ø)
x/evm/keeper/state_transition.go 78.29% <57.14%> (-3.71%) ⬇️
x/evm/keeper/gas.go 89.47% <89.47%> (ø)
x/evm/keeper/config.go 92.10% <92.10%> (ø)
app/ante/eth.go 80.08% <100.00%> (+0.08%) ⬆️
x/evm/keeper/utils.go 85.71% <100.00%> (+3.74%) ⬆️

@fedekunze fedekunze merged commit 286f919 into main Dec 30, 2022
@fedekunze fedekunze deleted the fedekunze/cleanup-evm branch December 30, 2022 12:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant