Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Oscillation issue with pixel snapping + pixelToSnap default false #2348

Merged
merged 17 commits into from
Jul 2, 2022

Conversation

eonarheim
Copy link
Member

@eonarheim eonarheim commented Jun 12, 2022

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

This PR fixes an issue that could cause graphical oscillations to occur when near a pixel boundary. To fix this we add a small epsilon to the pixel snap to nudge pixels over a boundary.

This PR also switches the default snapToPixel default back to false

@github-actions github-actions bot added the bug This issue describes undesirable, incorrect, or unexpected behavior label Jun 12, 2022
@eonarheim eonarheim changed the title fix: Fix oscillation issue with pixel snapping fix: Oscillation issue with pixel snapping Jun 14, 2022
@eonarheim eonarheim changed the title fix: Oscillation issue with pixel snapping fix: Oscillation issue with pixel snapping + pixelToSnap default false Jul 2, 2022
@eonarheim eonarheim merged commit 5fa595d into main Jul 2, 2022
@eonarheim eonarheim deleted the fix/tweak-pixel-snapping branch July 2, 2022 02:32
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant