Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [#2347] EventDispatcher concurrent update issue and removal bug #2350

Merged
merged 3 commits into from
Jun 12, 2022
Merged

fix: [#2347] EventDispatcher concurrent update issue and removal bug #2350

merged 3 commits into from
Jun 12, 2022

Conversation

eonarheim
Copy link
Member

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Closes #2347

This PR fixes several issues in the ex.EventDispatcher

  • Concurrent updates of handlers was not handled well, this has been fixed by implementing deferred removal
  • If a handler didn't exist the wrong handler would be removed instead (classic splice(-1, 1) bug)

@github-actions github-actions bot added the bug This issue describes undesirable, incorrect, or unexpected behavior label Jun 12, 2022
@eonarheim eonarheim merged commit ad1bd3b into main Jun 12, 2022
@eonarheim eonarheim deleted the fix/2347-event-dispatcher-bugs branch June 12, 2022 17:57
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problems with EventDispatcher
1 participant
@eonarheim