Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Improve collision system performance #2351

Merged
merged 13 commits into from
Jun 28, 2022

Conversation

eonarheim
Copy link
Member

@eonarheim eonarheim commented Jun 14, 2022

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Closes #2341 updates colliders in pointer system regardless of Physics enabled

This PR adds a few changes to improve performance of the main loop when collisions are active.

  • Call collider update in pointer system
  • Cache computed values where possible
  • Avoid calculating transformations until absolutely necessary
  • Avoid calling methods in tight loops

@eonarheim eonarheim merged commit 82358d9 into main Jun 28, 2022
@eonarheim eonarheim deleted the perf/improve-collision-system-performance branch June 28, 2022 02:18
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: default CollisionType on Actor is incorrect
1 participant