Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed update Interpolation incorrect with child actors #2397

Merged
merged 5 commits into from
Jul 2, 2022

Conversation

eonarheim
Copy link
Member

@eonarheim eonarheim commented Jul 2, 2022

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

This PR fixes an unreleased issue where fixed step update interpolation was incorrect with child actors. The issue was global and local positions were mixed in the interpolate.

interpolation-bug

Changes:

  • Switch interpolation to use local positions for start and end

@github-actions github-actions bot added the bug This issue describes undesirable, incorrect, or unexpected behavior label Jul 2, 2022
@eonarheim eonarheim merged commit 2d095f1 into main Jul 2, 2022
@eonarheim eonarheim deleted the fix/interpolation-incorrect-child-actors branch July 2, 2022 17:02
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant