Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [#2403] Allow ex.Canvas and ex.Raster to have NPOT dimensions #2404

Merged
merged 3 commits into from
Jul 7, 2022
Merged

fix: [#2403] Allow ex.Canvas and ex.Raster to have NPOT dimensions #2404

merged 3 commits into from
Jul 7, 2022

Conversation

eonarheim
Copy link
Member

@eonarheim eonarheim commented Jul 7, 2022 •
edited
Loading

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Closes #2403

Changes:

  • Removes unnecessary POT enforcement in the ex.Raster base class
  • Removes all power of two code, webgl2 doesn't need this anymore

@github-actions github-actions bot added the bug This issue describes undesirable, incorrect, or unexpected behavior label Jul 7, 2022
@eonarheim eonarheim merged commit 8249e4f into main Jul 7, 2022
@eonarheim eonarheim deleted the fix/2403-canvas-dimensions branch July 7, 2022 14:02
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ex.Canvas forces dimensions to next size power of 2
1 participant
@eonarheim