Feature: Add tile map layer support with support of the z-index property #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eonarheim
requested changes
Nov 10, 2021
There was a problem hiding this comment.
@JumpLink This looks great! I have a couple requests before merge.
- Delete unused line
- Assign a default incrementing zindex to each tile layer, if the custom 'zindex' property override isn't present
- Running locally a couple tests are failing, please update those tests so they pass
npm run test
|
@eonarheim Okay I have
|
50 tasks
|
Wow @JumpLink you are awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation creates layers for each raw tiled layer with zindex support as suggested in the discussion on #255.
This PR replaces #256